Skip to content

fix(http): stop exposing active MCP session IDs on /health #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andesyteoss wants to merge 1 commit into from
Closed

fix(http): stop exposing active MCP session IDs on /health #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/server/http-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,11 +154,13 @@ app.delete("/mcp", async (req: Request, res: Response) => {

// Health check endpoint
app.get("/health", (_req: Request, res: Response) => {
// Only expose non-sensitive liveness data. Active session IDs are the
// sole authentication token for reusing an MCP transport on POST /mcp,
// so they must never be disclosed to unauthenticated callers.
res.status(200).json({
status: "ok",
server: server ? "initialized" : "initializing",
activeSessions: transports.size,
sessionIds: Array.from(transports.keys())
activeSessions: transports.size
});
});

Expand Down