fix: stdio enable error UI state - #104
Merged
Merged
Conversation
…hang - Add ServerDefinitionModal with Monaco editor for viewing server JSON - Wire "View JSON" button in ServerDetailModal (Discover tab) - Add "View Definition" menu item in ServerActionMenu (My Servers tab) - Fix servers stuck showing "Connecting..." after restart by fetching runtime statuses in loadData() - Fix infinite render loop caused by inline onFeaturesChange callback recreating subscriptions every render (use useRef pattern) - Fix OAuth flow immediately cancelled on enable by using ConnectionContext::auto() instead of ConnectionContext::new() - Fix button visibility: move opacity-60 from card to info section only - Improve action menu button styling with visible background - Make getServerAction resilient to oauth_connected without auth type - Add unit and E2E tests for new features Signed-off-by: Myko <myko@mcpmux.com> Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
- Add data-testid attributes to ServerActionMenu button and menu items
(action-menu-{id}, view-logs-{id}, view-definition-{id}, uninstall-menu-{id})
- Add TC-SL-004 in server-lifecycle.wdio.ts: verifies action menu shows
View Logs, View Definition, and Uninstall items, and opens definition modal
Signed-off-by: Myko <myko@mcpmux.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How was it tested?
pnpm testpassespnpm lintpassespnpm typecheckpassesChecklist
git commit -s)