Skip to content

feat: add select, file_path, and directory_path input types - #121

Merged
its-mash merged 2 commits into
mainfrom
claude/feat-input-types
Feb 18, 2026
Merged

feat: add select, file_path, and directory_path input types#121
its-mash merged 2 commits into
mainfrom
claude/feat-input-types

Conversation

@its-mash

Copy link
Copy Markdown
Member

Summary

  • Add rendering for select, file_path, and directory_path input types in the server configuration UI
  • select renders a dropdown from predefined options on the input definition
  • file_path and directory_path render a text input with a native file/directory picker button via tauri-plugin-dialog
  • Update InputDefinition TypeScript type with new type union and options field
  • Remove password input type (replaced by text + secret: true)
  • Fix clippy warning in shell_env.rs (conditional #[cfg(unix)] import)

Changes

  • ServersPage.tsx: Add 3 new case branches in renderInput() switch
  • registry.ts: Update InputDefinition.type union and add options field
  • Cargo.toml / lib.rs / capabilities: Integrate tauri-plugin-dialog
  • package.json: Add @tauri-apps/plugin-dialog dependency
  • tests/ts/setup.ts: Add dialog plugin mock for test environment
  • shell_env.rs: Gate tracing import behind #[cfg(unix)]

Test plan

  • Verify select dropdown renders with options for servers like Playwright (browser select)
  • Verify file_path picker opens native file dialog and populates the text input
  • Verify directory_path picker opens native directory dialog and populates the text input
  • Verify text + secret: true still renders as password input (replacing old password type)
  • Run pnpm test:ts — existing tests pass with new dialog mock

Add frontend rendering for the three missing InputType variants:
- select: dropdown populated from input.options
- file_path: text input with native file picker via Tauri dialog
- directory_path: text input with native directory picker via Tauri dialog

Also adds tauri-plugin-dialog dependency, updates TypeScript types
and JSON schemas with options field for select inputs, and fixes
unused tracing imports on Windows in shell_env.rs.

Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
@its-mash
its-mash merged commit 942ee1a into main Feb 18, 2026
13 checks passed
@its-mash
its-mash deleted the claude/feat-input-types branch February 18, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant