Skip to content

refactor: remove Password and Textarea from InputType enum #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
its-mash merged 2 commits into from
Feb 19, 2026
Merged

refactor: remove Password and Textarea from InputType enum #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f1c331
refactor: remove Password and Textarea from InputType enum
its-mash Feb 18, 2026
28efec9
fix: update test to use text input type instead of removed password v…
its-mash Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/mcpmux-core/src/domain/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ pub struct InputDefinition {
pub id: String,
pub label: String,
#[serde(default = "default_input_type")]
pub r#type: String, // "text", "password", etc.
pub r#type: String, // "text", "number", "boolean", "url", etc. Masking controlled by `secret` field.
#[serde(default)]
pub required: bool,
#[serde(default)]
Expand Down
6 changes: 3 additions & 3 deletions crates/mcpmux-core/src/registry/default-registry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
"id": "GITHUB_PERSONAL_ACCESS_TOKEN",
"label": "GitHub Personal Access Token",
"description": "A GitHub PAT with appropriate repository access",
"input_type": "password",
"input_type": "text",
"required": true,
"secret": true,
"obtain_url": "https://github.com/settings/tokens",
Expand Down Expand Up @@ -225,7 +225,7 @@
"id": "BRAVE_API_KEY",
"label": "Brave API Key",
"description": "Your Brave Search API key",
"input_type": "password",
"input_type": "text",
"required": true,
"secret": true,
"obtain_url": "https://brave.com/search/api/",
Expand Down Expand Up @@ -267,7 +267,7 @@
"id": "SLACK_BOT_TOKEN",
"label": "Slack Bot Token",
"description": "Your Slack bot token (xoxb-...)",
"input_type": "password",
"input_type": "text",
"required": true,
"secret": true,
"obtain_url": "https://api.slack.com/apps",
Expand Down
2 changes: 1 addition & 1 deletion crates/mcpmux-core/src/registry/schema.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ mod tests {
{
"id": "GITHUB_PERSONAL_ACCESS_TOKEN",
"label": "GitHub Personal Access Token",
"type": "password",
"type": "text",
"required": true,
"secret": true,
"obtain": {
Expand Down
4 changes: 0 additions & 4 deletions crates/mcpmux-core/src/registry/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,6 @@ pub enum InputType {
/// Single-line text input
#[default]
Text,
/// Multi-line text input
Textarea,
/// Password/secret input (masked)
Password,
/// Boolean toggle
Boolean,
/// Numeric input
Expand Down
Loading