refactor: remove client active/inactive status - #138
Closed
its-mash wants to merge 2 commits into
Closed
Conversation
The has_active_tokens field and clients_with_tokens in-memory set tracked whether clients had been issued tokens to show Active/Inactive status badges in the UI. This status was unreliable (in-memory only, lost on restart) and not needed. Removes the status badges from the clients page, the tracking state from the gateway, and the field from both gateway and Tauri response structs. Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
has_active_tokensfield from gateway and Tauri OAuth client response structsclients_with_tokensin-memory HashSet fromGatewayStateThe status was unreliable since it was tracked in-memory only (lost on gateway restart) and provided no actionable information to users.
Test plan
cargo clippy --workspace -- -D warningspassescargo test --workspace --libpasses (32 tests)pnpm typecheckpassespnpm test:tspasses (182 tests)