fix(servers): pin config-modal footer (#163) + silent Windows updates - #165
Merged
Conversation
The "Configure <server>" modal kept its header, inputs, and action buttons inside a single scrolling container, so on servers with long credential/args/env forms the Save and Cancel buttons scrolled below the fold and were easy to miss. Restructure the modal as a flex column: fixed header, a scrollable body for the inputs (flex-1 overflow-y-auto), and a pinned footer (border-top) so Save/Cancel are always visible regardless of form length. All data-testids preserved. Closes #163 Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Set plugins.updater.windows.installMode to "quiet" so the auto-updater applies updates with no installer window or progress dialog — the app just downloads, swaps, and relaunches into the new version, rather than flashing an installer that looks like a manual setup. "quiet" needs no elevation for the per-user (currentUser) NSIS install we ship, and install failures still reject through downloadAndInstall (the launch flow logs them; the Settings checker surfaces them), so silent mode doesn't hide errors. Switch to "passive" if a progress bar is ever wanted. Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small, independent UX fixes.
1. Config modal — pinned Save/Cancel footer (closes #163)
The "Configure <server>" modal kept its header, inputs, and action buttons in one scrolling container, so on servers with long credential/args/env forms (e.g. Confluent) the Save / Cancel buttons scrolled below the fold.
Restructured the modal as a flex column: fixed header → scrollable inputs body (
flex-1 overflow-y-auto) → pinned footer (border-top). Save/Cancel are now always visible regardless of form length. Alldata-testids preserved (E2E unaffected).2. Silent Windows auto-update
Set
plugins.updater.windows.installModeto"quiet"so updates apply with no installer window or progress dialog — the app downloads, swaps, and relaunches into the new version instead of flashing something that looks like a manual install."quiet"needs no elevation for our per-user (currentUser) NSIS install.downloadAndInstall(launch flow logs them; the Settings checker surfaces them), so silent mode doesn't hide errors."passive"if you ever want a progress bar.Validation
tsc --noEmit✓, ESLint ✓ (0 errors), pre-commit hook (fmt + clippy + eslint + typecheck) ✓ on both commits. tauri.conf.json validated as JSON.