feat: @mux UX + Windows updater fix + minimal-first optimization - #171
Merged
Conversation
Two small discoverability nudges around tool optimization: - FeatureSets tab: add a branded "Let your AI build these for you" hint showing the `@mux optimize` chat affordance — the assistant can discover tools, compose a FeatureSet, and pin it to the current folder, each gated behind a one-click approval. - Meta-tool approval dialog: add a "Prefer not to be asked? Manage approval prompts" link that denies the current request (fail-closed, so the client is not left hanging for the 60s broker timeout) and routes to the Built-in tab, where the "Require approval for tool changes" switch can turn these prompts off. Covered by a new MetaToolApprovalDialog test asserting the link denies and navigates to builtin-servers. Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
The Windows auto-updater shipped a per-machine MSI installed silently (installMode "quiet"). Per-machine MSI upgrades need elevation; "quiet" suppresses the UAC prompt and apps run non-elevated by default, so the silent install failed (1603 / "must be Administrator") for ordinary users — and since the app quits to apply the update, it looked like a crash/loop. This affected any non-elevated user on auto-update, not just dev. - bundle.targets: drop "msi" (was "all"). Windows now ships NSIS only, which is already configured per-user (nsis.installMode "currentUser") — so updates install without elevation. The updater manifest will reference the NSIS "-setup.exe"; the api.mcpmux.com resolver rewrites URLs filename-agnostically, so no worker change is needed. - updater.windows.installMode: "quiet" -> "passive". Shows a small progress UI and, crucially, surfaces a UAC prompt if elevation is ever needed instead of failing invisibly. With per-user NSIS the normal path still needs no elevation. - App.tsx: skip the startup auto-update entirely when import.meta.env.DEV (i.e. under `pnpm dev`) — otherwise a dev build detects a newer published release, installs it over the dev build, and relaunches, so local changes never appear. Production builds are unaffected. Tests: App update-banner suite stubs DEV=false to keep exercising the production flow; all 12 pass. Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Optimizing was slow because the model dumped the whole catalog and built one large FeatureSet upfront. Add concise (token-cheap) guidance steering it to start minimal and expand on demand: - Server instructions: "start minimal, expand later" one-liner. - mcpmux_list_all_tools: prefer mcpmux_search_tools; flag the full dump as token-heavy. - mcpmux_manage_feature_set: prefer a small initial set expanded later. Guidance-only; no tool behavior change. Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates #168, #169, #170 into one branch.
@mux optimizehint on FeatureSets; "Manage approval prompts" opt-out link on the approval dialog (denies + routes to Built-in tab).installModequiet→passive, skip auto-update underpnpm dev. Fixes the per-machine-MSI silent-install failure that looked like a crash for non-admin users.No mcpmux API/worker change needed: the resolver rewrites manifest URLs filename-agnostically. Tests green (vitest + clippy/fmt/eslint/typecheck).