feat(workspaces): setting to disable the new-folder mapping prompt - #177
Merged
Conversation
Adds an "Ask to map new folders" toggle (on by default) so users who find the "map this folder?" sheet noisy can turn it off — from Settings → Workspaces or a "stop asking" link in the sheet itself. The folder still works on the default Starter set when the prompt is off. - Backend: get/set_workspace_mapping_prompt_enabled commands (key `workspaces.mapping_prompt_enabled`, default true via a testable helper). - Sheet: reads the setting fresh on each `workspace-needs-binding` event and swallows it when disabled (no re-subscribe needed); adds an in-sheet "stop asking about new folders" link that turns it off and closes. - Settings: new Workspaces card with the toggle. - Tests: Rust `test_mapping_prompt_enabled_defaults_on`; TS sheet gating (enabled shows / disabled hides) + the disable link. Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The "map this folder?" sheet pops whenever a connected app opens an unmapped folder. It's helpful, but some users find it noisy — so add a way to turn it off. On by default. With it off, an unmapped folder still works (it uses the default Starter set); the user just isn't prompted.
Changes
get/set_workspace_mapping_prompt_enabledcommands (keyworkspaces.mapping_prompt_enabled, default true via a testablemapping_prompt_enabled_fromhelper). Registered in the invoke handler.WorkspaceBindingSheet) — reads the setting fresh on eachworkspace-needs-bindingevent (so a toggle takes effect immediately, no re-subscribe) and swallows the event when disabled. Adds an in-sheet "Asked too often? Stop asking about new folders" link that turns the setting off and closes — the quick escape hatch.Tests
test_mapping_prompt_enabled_defaults_on(missing/garbage → on; only"false"disables).WorkspaceBindingPrompt.test.tsx— sheet shows when enabled, stays hidden when disabled, and the disable link callsset_workspace_mapping_prompt_enabled({enabled:false})then closes.Local validation: desktop crate settings tests, typecheck, ESLint (0 errors), fmt. Pre-commit (fmt + clippy incl. desktop + eslint + typecheck) green.