Skip to content

fix(gateway): restore disabled auth on auto-start - #211

Closed
its-mash wants to merge 138 commits into
mainfrom
agent/restore-gateway-auth-setting-on-autostart
Closed

fix(gateway): restore disabled auth on auto-start#211
its-mash wants to merge 138 commits into
mainfrom
agent/restore-gateway-auth-setting-on-autostart

Conversation

@its-mash

Copy link
Copy Markdown
Member

Summary

  • centralize loading of the persisted inbound-auth setting
  • apply the setting to both manual and automatic gateway startup
  • add regression coverage for the secure default and persisted disabled state

Root cause

start_gateway restored gateway.auth_disabled after creating GatewayState, but the desktop auto-start path created the same state without restoring the setting. Relaunching the app therefore reverted a configured no-auth gateway to auth-required until the user toggled the setting again.

Impact

When Disable authentication is enabled, relaunching McpMux now preserves that behavior. A missing setting or repository read failure still defaults to authentication required.

Validation

  • cargo +1.88.0 fmt --all -- --check
  • cargo +1.88.0 test -p mcpmux --lib — 34 passed
  • cargo +1.88.0 clippy -p mcpmux --lib -- -D warnings -A clippy::uninlined_format_args

The narrow Clippy allowance is for a pre-existing Rust 1.88 lint in crates/mcpmux-core/build.rs; the changed files pass with warnings denied.

its-mash and others added 30 commits February 9, 2026 12:33
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Signed-off-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
#71)

Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
…61)

Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Co-authored-by: Mohammod Al Amin Ashik <alamin.ashik@sitecore.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Signed-off-by: Claude <noreply@anthropic.com>
Co-authored-by: Mohammod Al Amin Ashik <alamin.ashik@sitecore.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
… logs (#76)

Signed-off-by: Claude <noreply@anthropic.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Signed-off-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
… step (#82)

Signed-off-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Myko <maa.ashik00@gmail.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
its-mash and others added 28 commits June 18, 2026 20:34
)

Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
#174)

Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: its-mash <maa.ashik00@gmail.com>
…pace (#179)

Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…lder setup (#182)

Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
…dvertising) (#187)

Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
…flows (#188)

Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
…189)

Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
…ect (#190)

Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…#198)

Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Co-authored-by: its-mash <maa.ashik00@gmail.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Co-authored-by: its-mash <maa.ashik00@gmail.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Co-authored-by: its-mash <maa.ashik00@gmail.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Co-authored-by: its-mash <maa.ashik00@gmail.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Co-authored-by: its-mash <maa.ashik00@gmail.com>
Co-authored-by: its-mash <maa.ashik00@gmail.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Co-authored-by: its-mash <maa.ashik00@gmail.com>
…#200)

Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
)

Co-authored-by: Mohammod Al Amin Ashik <alamin.ashik@sitecore.com>
Signed-off-by: Xuleileon <xuleileon19932022@163.com>
@its-mash its-mash closed this Jul 15, 2026
@its-mash
its-mash deleted the agent/restore-gateway-auth-setting-on-autostart branch July 15, 2026 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants