fix(gateway): restore disabled auth on auto-start - #213
Closed
its-mash wants to merge 5 commits into
Closed
Conversation
Signed-off-by: Xuleileon <xuleileon19932022@163.com>
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Comment on lines
+38
to
+53
| import { | ||
| createSpace, | ||
| createFeatureSet, | ||
| installServer, | ||
| getDefaultSpace, | ||
| refreshRegistry, | ||
| enableServerV2, | ||
| emitEvent, | ||
| approveOAuthClient, | ||
| seedServerFeatures, | ||
| listFeatureSetsBySpace, | ||
| listServerFeatures, | ||
| listClients, | ||
| addFeatureToSet, | ||
| grantOAuthClientFeatureSet, | ||
| } from '../helpers/tauri-api'; |
Member
Author
|
Superseded — the contributor's original PR #205 has been reopened; this duplicate re-authored their work under my name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
start_gatewayrestoredgateway.auth_disabledafter creatingGatewayState, but the desktop auto-start path created the same state without restoring the setting. Relaunching the app therefore reverted a configured no-auth gateway to auth-required until the user toggled the setting again.Impact
When Disable authentication is enabled, relaunching McpMux now preserves that behavior. A missing setting or repository read failure still defaults to authentication required.
Validation
cargo +1.88.0 fmt --all -- --checkcargo +1.88.0 test -p mcpmux --lib— 34 passedcargo +1.88.0 clippy -p mcpmux --lib -- -D warnings -A clippy::uninlined_format_argsThe narrow Clippy allowance is for a pre-existing Rust 1.88 lint in
crates/mcpmux-core/build.rs; the changed files pass with warnings denied.