feat: capture MCP protocol logging notifications in server connection logs - #76
Merged
Merged
Conversation
… logs The McpClientHandler was missing an on_logging_message implementation, causing all MCP protocol notifications/message log entries from servers to be silently dropped. Only connection lifecycle events and stderr were visible. This adds: - LogSource::Server variant for MCP protocol log messages - on_logging_message handler that forwards to ServerLogManager - LoggingLevel -> LogLevel mapping (MCP -> internal) - Cyan color for 'server' source in the log viewer UI Signed-off-by: Claude <noreply@anthropic.com> https://claude.ai/code/session_01CHdV8mcWB77r9Tf27K6o9f Signed-off-by: Claude <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com> https://claude.ai/code/session_01CHdV8mcWB77r9Tf27K6o9f Signed-off-by: Claude <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com> https://claude.ai/code/session_01CHdV8mcWB77r9Tf27K6o9f Signed-off-by: Claude <noreply@anthropic.com>
TokioChildProcess::new() overrides stderr set via .configure() with Stdio::inherit(), so process stderr was never captured. Switch to the builder pattern (TokioChildProcess::builder().stderr(Stdio::piped()) .spawn()) which correctly returns a ChildStderr handle. Replace blocking os_pipe + spawn_blocking with async tokio BufReader + lines() for idiomatic async stderr reading. Remove os_pipe dep from gateway crate. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
--experimental-strip-types requires Node 22.6+, but CI runs Node 20. The stub server process died immediately with "bad option", causing MCP handshake failures and TC-PL-002 to fail. Signed-off-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
…ash/mcp-mux into claude/studio-logs-mcp-server-D5WJm
This was referenced Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The McpClientHandler was missing an on_logging_message implementation,
causing all MCP protocol notifications/message log entries from servers
to be silently dropped. Only connection lifecycle events and stderr were
visible. This adds: