Skip to content

Adjustable starting pages - #3

Merged
alexlanz merged 2 commits into
masterfrom
different-starting-pages
May 26, 2021
Merged

Adjustable starting pages#3
alexlanz merged 2 commits into
masterfrom
different-starting-pages

Conversation

@alexlanz

Copy link
Copy Markdown
Member

No description provided.

Comment thread readme.md
- `maxPages`: The maximum amount of pages that should be shown (default: 5)
- `config`: A configuration object containing the following possible configuration values:
- `firstPage`: The first page of the pagination (default: 1)
- `maxPages`: The maximum amount of pages that should be shown (default: 5)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you want to have a default for maxPages? How would I say that I want all pages to be shown?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the number of pages that should be shown blow. For example if you have hundreds of results, then we show only the next 2 pages. Otherwise, it breaks most of the times on mobile.

Do you know a sceznario, where you want to show all pages?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the feature, but I would just keep the possibility to also show all pages. I think a lib should support that.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you than also stick to this config object? Because in our case with our designs we then always have to pass this parameter.

@alexlanz
alexlanz merged commit fe01637 into master May 26, 2021
@alexlanz
alexlanz deleted the different-starting-pages branch May 26, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants