-
Notifications
You must be signed in to change notification settings - Fork 0
Adjustable starting pages #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| import { calculatePagination } from '../index' | ||
|
|
||
| it('should return no pagination if not enough items are given', () => { | ||
| const page = 0 | ||
| const size = 5 | ||
| const total = 2 | ||
| const pagination = calculatePagination(page, size, total, { firstPage: 0 }) | ||
|
|
||
| expect(pagination).toBeNull() | ||
| }) | ||
| it('should return only a few pages', () => { | ||
| const page = 1 | ||
| const size = 5 | ||
| const total = 15 | ||
| const pagination = calculatePagination(page, size, total, { firstPage: 0 }) | ||
|
|
||
| expect(pagination).not.toBeNull() | ||
| expect(pagination?.pages).toHaveLength(3) | ||
|
|
||
| expect(pagination?.pages[0].number).toBe(0) | ||
| expect(pagination?.pages[0].isCurrent).toBeFalsy() | ||
| expect(pagination?.pages[1].number).toBe(1) | ||
| expect(pagination?.pages[1].isCurrent).toBeTruthy() | ||
| expect(pagination?.pages[2].number).toBe(2) | ||
| expect(pagination?.pages[2].isCurrent).toBeFalsy() | ||
| }) | ||
| it('should return the maximum number of pages', () => { | ||
| const page = 4 | ||
| const size = 5 | ||
| const total = 50 | ||
| const maxPages = 5 | ||
| const pagination = calculatePagination(page, size, total, { | ||
| firstPage: 0, | ||
| maxPages: maxPages, | ||
| }) | ||
|
|
||
| expect(pagination).not.toBeNull() | ||
| expect(pagination?.pages).toHaveLength(5) | ||
|
|
||
| expect(pagination?.pages[0].number).toBe(2) | ||
| expect(pagination?.pages[0].isCurrent).toBeFalsy() | ||
| expect(pagination?.pages[1].number).toBe(3) | ||
| expect(pagination?.pages[1].isCurrent).toBeFalsy() | ||
| expect(pagination?.pages[2].number).toBe(4) | ||
| expect(pagination?.pages[2].isCurrent).toBeTruthy() | ||
| expect(pagination?.pages[3].number).toBe(5) | ||
| expect(pagination?.pages[3].isCurrent).toBeFalsy() | ||
| expect(pagination?.pages[4].number).toBe(6) | ||
| expect(pagination?.pages[4].isCurrent).toBeFalsy() | ||
| }) | ||
| it('should disable the previous link', () => { | ||
| const page = 0 | ||
| const size = 5 | ||
| const total = 10 | ||
| const pagination = calculatePagination(page, size, total, { firstPage: 0 }) | ||
|
|
||
| expect(pagination).not.toBeNull() | ||
|
|
||
| expect(pagination?.previous.number).toBe(0) | ||
| expect(pagination?.previous.isDisabled).toBeTruthy() | ||
|
|
||
| expect(pagination?.next.number).toBe(1) | ||
| expect(pagination?.next.isDisabled).toBeFalsy() | ||
|
|
||
| expect(pagination?.pages[0].isCurrent).toBeTruthy() | ||
| expect(pagination?.pages[1].isCurrent).toBeFalsy() | ||
| }) | ||
| it('should disable the next link', () => { | ||
| const page = 1 | ||
| const size = 5 | ||
| const total = 10 | ||
| const pagination = calculatePagination(page, size, total, { firstPage: 0 }) | ||
|
|
||
| expect(pagination).not.toBeNull() | ||
|
|
||
| expect(pagination?.previous.number).toBe(0) | ||
| expect(pagination?.previous.isDisabled).toBeFalsy() | ||
|
|
||
| expect(pagination?.next.number).toBe(1) | ||
| expect(pagination?.next.isDisabled).toBeTruthy() | ||
|
|
||
| expect(pagination?.pages[0].isCurrent).toBeFalsy() | ||
| expect(pagination?.pages[1].isCurrent).toBeTruthy() | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you want to have a default for maxPages? How would I say that I want all pages to be shown?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the number of pages that should be shown blow. For example if you have hundreds of results, then we show only the next 2 pages. Otherwise, it breaks most of the times on mobile.
Do you know a sceznario, where you want to show all pages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the feature, but I would just keep the possibility to also show all pages. I think a lib should support that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you than also stick to this config object? Because in our case with our designs we then always have to pass this parameter.